-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an ability to import the Git Configuration #1136
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's merge it for 7.89.x after 7.88.0 release is out
we would also need review from @akurinnoy and @dmytro-ndp / @artaleks9
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
… Git Configuration
Verified on Che with |
…ort the Git Configuration
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
… to import the Git Configuration
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
/test v14-dashboard-happy-path |
…ability to import the Git Configuration
It seems, the
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
…add an ability to import the Git Configuration
… feat: add an ability to import the Git Configuration
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
… fixup! feat: add an ability to import the Git Configuration
… fixup! fixup! feat: add an ability to import the Git Configuration
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
… fixup! fixup! fixup! feat: add an ability to import the Git Configuration
@olexii4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.16 :: dashboard_3.x/508: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7106: Console, Changes, Git Data |
Build 3.16 :: push-latest-container-to-quay_3.x/4719: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7084: dashboard : 3.x :: Build 62434869 : quay.io/devspaces/dashboard-rhel8:3.16-6 |
Build 3.16 :: update-digests_3.x/6980: Console, Changes, Git Data |
Build 3.16 :: dashboard_3.x/508: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7106 triggered |
Build 3.16 :: operator-bundle_3.x/3216: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7107: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7085: devspaces-operator-bundle : 3.x :: Failed in 62435889 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
This PR adds an ability to import the Git Configuration.
What issues does this PR fix or reference?
fixes eclipse-che/che#22782
Is it tested? How?
The demo video.