Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an ability to import the Git Configuration #1136

Merged
merged 14 commits into from
Jul 8, 2024
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 24, 2024

What does this PR do?

This PR adds an ability to import the Git Configuration.

What issues does this PR fix or reference?

fixes eclipse-che/che#22782

Is it tested? How?

The demo video.

Знімок екрана 2024-06-24 о 16 27 08

Знімок екрана 2024-06-24 о 16 21 52

@che-bot
Copy link
Contributor

che-bot commented Jun 24, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's merge it for 7.89.x after 7.88.0 release is out
we would also need review from @akurinnoy and @dmytro-ndp / @artaleks9

@openshift-ci openshift-ci bot removed the lgtm label Jun 26, 2024
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

@ibuziuk ibuziuk requested a review from artaleks9 July 1, 2024 13:52
@artaleks9
Copy link
Contributor

Verified on Che with quay.io/eclipse/che-dashboard:pr-1136 - works properly

@openshift-ci openshift-ci bot removed the lgtm label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Jul 2, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

@olexii4
Copy link
Contributor Author

olexii4 commented Jul 2, 2024

/test v14-dashboard-happy-path
/test v14-e2e-puppeteer
/test v14-images

@eclipse-che eclipse-che deleted a comment from codecov bot Jul 2, 2024
@artaleks9
Copy link
Contributor

It seems, the dashboard-happy-path test is fail by an infrastructure problem related to Openshift-CI:

Could not retrieve mirrorlist http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=container error was
14: curl#6 - "Could not resolve host: mirrorlist.centos.org; Unknown error"

Copy link

github-actions bot commented Jul 3, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

olexii4 added 2 commits July 3, 2024 16:27
…add an ability to import the Git Configuration
… feat: add an ability to import the Git Configuration
Copy link

github-actions bot commented Jul 4, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

olexii4 added 2 commits July 4, 2024 16:30
… fixup! feat: add an ability to import the Git Configuration
… fixup! fixup! feat: add an ability to import the Git Configuration
Copy link

github-actions bot commented Jul 4, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

1 similar comment
Copy link

github-actions bot commented Jul 4, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

… fixup! fixup! fixup! feat: add an ability to import the Git Configuration
Copy link

openshift-ci bot commented Jul 4, 2024

@olexii4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-dashboard-happy-path f336ac3 link true /test v14-dashboard-happy-path
ci/prow/v14-e2e-puppeteer f336ac3 link true /test v14-e2e-puppeteer
ci/prow/v14-images f336ac3 link true /test v14-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

github-actions bot commented Jul 4, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1136

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1136", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 773fe5f into main Jul 8, 2024
13 of 16 checks passed
@olexii4 olexii4 deleted the CHE-22782 branch July 8, 2024 13:42
@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/508: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/508: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7106 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/7085: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62435889 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Add an ability add an ability to import the Git Configuration
6 participants