Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List box, display text: enable the parameter task to handle the display text of multi selections for list box parameters #1981

Closed
speckyspooky opened this issue Nov 17, 2024 · 1 comment · Fixed by #1982
Assignees
Labels
Enhancement Small change to improve the current supported functionality
Milestone

Comments

@speckyspooky
Copy link
Contributor

The current handling of parameters and there display text doesn't support the option to get the selected display text results of a list box which is marked as multi selection.
The display text implementation allows only to get the value of a single selection list and for multi selections is the return value "null".
This handling is offical documented at source code side.

This enhancement is created to implements the option of display text for both versions of single selection and multi selection for list boxes.
There are different tickets where the feature was addressed and on of the latest is #1967.

I will create a PR for the enhancement.

@speckyspooky speckyspooky added the Enhancement Small change to improve the current supported functionality label Nov 17, 2024
@speckyspooky speckyspooky added this to the 4.18 milestone Nov 17, 2024
@speckyspooky speckyspooky self-assigned this Nov 17, 2024
speckyspooky added a commit to speckyspooky/birt that referenced this issue Nov 17, 2024
@speckyspooky
Copy link
Contributor Author

For the testing I used a test report with 3 list boxes:

  • 2 multi selection lists
  • 1 single selection list

The following options are tested to get the display text:

params["paramMultiSelectionList"].displayText
params["paramMultiSelectionList"].displayText.toString()
params["paramMultiSelectionList"].displayText.join("~")
reportContext.getParameterDisplayText("paramMultiSelectionList").join("~");

The following 2 screens display the different report creation options of Run-task & RunAndRender-task.
For a better understanding I add the "value"-option and the "display text"-option of the parameters at the test report.

Run-task

grafik

RunAndRender-task

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Small change to improve the current supported functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant