This repository has been archived by the owner on May 7, 2020. It is now read-only.
[WIP] Fix thing creation with updated XML #6537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
|
Looks like it could work - I wonder, if there would be a simpler way e.g. when adding a thing to the registry. Need to think about it. |
htreu
reviewed
Jan 17, 2019
| } | ||
| Thing newThing = thingBuilder.build(); | ||
|
|
||
| if (thingsList.contains(storedThing)) { |
There was a problem hiding this comment.
when will this check hold true? New things are only added to the thingsList in the else case in line 226. So the storedThing is not supposed to be in there. Besides that it should also be exchanged by the newThing entity.
|
Looks like a good start for me as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2555
This is intended as a design-idea. I would appreciate some comments.
Basically this lets the thing creation wait for the handler factory to be available and then checks if the stored managed thing has all channels a newly created thing of the same type would have.
Missing channels are added, channels with changed
ChannelTypeUIDor accepted item-types are updated to the new version.Removed channels are not removed, which is a little bit unsatisfying and still different from the textual configuration. I'll have to check if it is possible to find out which channels (especially in extensible things) are user-added and should be preserved.