Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Static Code Analysis Tool reports unaddressed TODO comments in XmlDocumentBundleTracker #5275

Closed
kssimova opened this issue Mar 20, 2018 · 1 comment
Closed

Static Code Analysis Tool reports unaddressed TODO comments in XmlDocumentBundleTracker #5275

kssimova opened this issue Mar 20, 2018 · 1 comment

Comments

@kssimova
Copy link
Contributor

I'm currently fixing issues in Smarthome, found by the Static Code Analysis Tool. The included check from Checkstyle - TodoCommentCheck, which checks for left // todo comments in javadoc, reports XmlDocumentBundleTracker and I can not find an open issue with discussion about it.

Comment had been introduced with this commit.

@SJKA Аs an author, do you think that this is still an issue or we can remove the TODO comment?
@sjsf
Copy link
Contributor

sjsf commented Apr 18, 2018

Yes, it is - but it is also covered by #1896, therefore the comment can be removed from the code.

triller-telekom added a commit to triller-telekom/smarthome that referenced this issue Apr 20, 2018
@triller-telekom
Removed TODOs from Digitalstrom binding and XmlDocumentBundleTracker
a8625b0 
As discussed with the authors in the linked issues.

Fixes eclipse-archived#5259
Fixes eclipse-archived#5272
Fixes eclipse-archived#5271
Fixes eclipse-archived#5269
Fixes eclipse-archived#5263
Fixes eclipse-archived#5275

Signed-off-by: Stefan Triller <[email protected]>
@triller-telekom triller-telekom mentioned this issue Apr 20, 2018
Merged
sjsf pushed a commit that referenced this issue Apr 20, 2018
@triller-telekom
Removed TODOs from Digitalstrom binding and XmlDocumentBundleTracker (#…
4c5ef27 
…5432)

As discussed with the authors in the linked issues.

Fixes #5259
Fixes #5272
Fixes #5271
Fixes #5269
Fixes #5263
Fixes #5275

Signed-off-by: Stefan Triller <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjsf @kssimova