Allow to deactivate Rich Presence integration #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration can now be deactivated from the plug-in's Preferences page. When the integration is deactivated, the plug-in still works as usual, the only difference is that it does not send any information to Discord anymore.
The elapsed time was reset each time the integration was deactivated then activated again.
In the end, this class merely instantiate a new PreferredRichPresence when show() is called. This does not worth the overweight of maintaining a whole class.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
===========================================
- Coverage 74.78% 74.19% -0.6%
- Complexity 179 193 +14
===========================================
Files 22 22
Lines 595 620 +25
Branches 62 63 +1
===========================================
+ Hits 445 460 +15
- Misses 135 147 +12
+ Partials 15 13 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to deactivate the integration from the plug-in Preferences page (
Window > Preferences > Discord Rich Presence > Activate Rich Presence Integration).Eclipse IDE does not communicate with Discord when the integration is deactivated, which means that Discord does not display Playing Eclipse IDE anymore.