lsp server not working well with mini.completion

[swahpy]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.completion

Question

Hi, first I'm really grateful for what you did in the mini community. I like mini ones very much and mostly used them everyday together with several other necessary ones(lspconfig, treesitter etc.) Really really great!
Recently I switched from nvim-cmp to mini.completion and mini.snippets. With mini.completion I was having trouble to set it as expected, especially about several note-taking lsp servers.

At present I tried marksman and zk(zk-nvim). Both provide functionality like link completion. I also configured it as noted in the doc. A quick example like below,

-- marksman
▒ lspconfig.marksman.setup {
▒   capabilities = capabilities,
▒   on_attach = on_attach,
}
▒
▒ -- zk
▒ require("zk").setup {
▒   picker = "minipick",
▒   lsp = {
▒     -- `config` is passed to `vim.lsp.start_client(config)`
▒     config = {
▒     ╎ cmd = { "zk", "lsp" },
▒     ╎ name = "zk",
▒     ╎ on_attach = on_attach,
▒     },
▒
▒     -- automatically attach buffers in a zk notebook that match the given filetypes
▒     auto_attach = {
▒       enabled = true,
▒       filetypes = { "markdown" },
▒     },
▒   },
▒ }

in on_attach I have below setup,

-- Set up 'mini.completion' LSP part of completion
vim.bo[bufnr].omnifunc = "v:lua.MiniCompletion.completefunc_lsp"

But even with all above, the link completion functionality is not available. I'm not sure it is caused by mini.completion or my non-proper setup. But this worked with nvim-cmp. Looking forward to any hints and suggestions. Thank you in advance.

[echasnovski]

Thanks for kind words!

I am not really familiar with any of the LSP servers and plugins, but there is a #826. Does it describe similar use case for "link completion" (i.e. pressing [[ not working)?

[swahpy]

Thanks for kind words!

I am not really familiar with any of the LSP servers and plugins, but there is a #826. Does it describe similar use case for "link completion" (i.e. pressing [[ not working)?

Hi thank you for your quick reply. After going through the thread, I think I'm not capable for tweaking these stuff, because I have no idea about all the things between lsp client and server... For the time being I just swtich back to nvim-cmp or try blink.cmp. Thank you anyway!

[echasnovski]

ecause I have no idea about all the things between lsp client and server...

The bottom line of that issue was that it looked like a LSP server not fully following the LSP spec. Not sure why this works in other completion engines.

[swahpy]

maybe a quick update. I tried blink.cmp. and it has completion items after setting require('blink.cmp').get_lsp_capabilities(config.capabilities) in lspconfig(so no completion items in mini.completion may be due to only vim.bo[bufnr].omnifunc = "v:lua.MiniCompletion.completefunc_lsp" in lsp is not enough? just my guess :)). But I have to say it didn't work very well, either. The problem should come from zk lsp server itself. So I now return back to mini.completion again. I like its simplicity and pure nature. Maybe I should refer to thread [#826] to learn something about setting up process_items in mini.completion.

[swahpy]

apologize.. last update. I finally found the solution. In the zk documentation about lsp configuration, there is one option said Indicates whether additionalTextEdits will be used to remove the trigger characters,zk lsp configuration. After I setup this option in zk configuration, it finally worked.
Not sure this change happened before or after [#826], but let me also post the solution there..
Finally I have mini.completion in place and working well. A great day!

[echasnovski]

Thanks for sharing! That's really helpful for future zk and 'mini.completion' users.