Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skipXmlComments as internal arg for OWS http XML requests #126

Closed
eblondel opened this issue Mar 21, 2024 · 0 comments
Closed

Add skipXmlComments as internal arg for OWS http XML requests #126

eblondel opened this issue Mar 21, 2024 · 0 comments
Assignees
@eblondel
Labels
enhancement OGC - WFS
Milestone
0.4

Comments

@eblondel
Copy link
Owner

By default, an skipXmlComments will be set to TRUE for any OWS HTTP request. This will be applied to remove eventual comments on the service XML response, now done systematically by default on XML requests.

In the case of WFS, for large data requests, this can be a bottleneck resulting in vector memory allocation errors, as spotted out in EMODnet/emodnet.wfs#164 This small enhancement will set skipXmlComments to FALSE for the WFS GetFeatures, likely not to contain XML comments, as we could find in ISO metadata for example.
@eblondel eblondel added this to the 0.4 milestone Mar 21, 2024
@eblondel eblondel self-assigned this Mar 21, 2024
eblondel added a commit that referenced this issue Mar 21, 2024
@eblondel
implement #126
30fab8f
eblondel added a commit that referenced this issue Mar 27, 2024
@eblondel
Update NEWS.md - add #126
1ea0790
eblondel added a commit that referenced this issue Jun 17, 2024
@eblondel
add #126 on NEWS.md
5a06704 
Merge branch 'master' of github.com:eblondel/ows4R

# Conflicts:
#	DESCRIPTION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eblondel eblondel

Labels
enhancement OGC - WFS
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@eblondel