Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eve characteristic AirQualityPPM #8

Closed
tobekas opened this issue Apr 3, 2019 · 3 comments
Closed

Eve characteristic AirQualityPPM #8

tobekas opened this issue Apr 3, 2019 · 3 comments

Comments

@tobekas
Copy link

tobekas commented Apr 3, 2019

Hi,
can you add Eve's characteristic "AirQualityPPM" to EveHomeKitTypes.js?

UID is E863F10B-079E-48FF-8F27-9C2605A29F52 and props are

{
    format: this.formats.FLOAT,
    unit: "ppm",
    maxValue: 5000,
    minValue: 0,
    minStep: 1,
    perms: [this.perms.READ, this.perms.NOTIFY]
};

see also: https://github.com/simont77/fakegato-history/wiki/Services-and-characteristics-for-Elgato-Eve-devices

@ebaauw
Copy link
Owner

ebaauw commented Apr 6, 2019

Added in v4.0.11. I named it AirParticulateDensity for consistency. There is a standard HomeKit AirParticulateDensity characteristic with these properties. There's also a standard AirQuality characteristic, which takes an int value from a predefined list (for Excellent, Good, etc) - more like the stars for the new Eve Room (with display).

See https://github.com/KhaosT/HAP-NodeJS/blob/0840ce52cc8015dd75fb21c098bf38cf9611ea4a/lib/gen/HomeKitTypes.js#L70 and https://github.com/KhaosT/HAP-NodeJS/blob/0840ce52cc8015dd75fb21c098bf38cf9611ea4a/lib/gen/HomeKitTypes.js#L114.

Do you know if the the new (with display) and old (without display) Eve Room are still using the custom characteristic? Eve tends to switch to standard characteristics, once they became available.

ebaauw added a commit that referenced this issue Apr 6, 2019
Add `AirParticulateDensity` charecteristic, see #8.
@tobekas
Copy link
Author

tobekas commented Apr 6, 2019

Thanks a lot! It's working!
I'm using the custom AirParticulateDensity characteristic (E863F10B) in combination with the standard AirQuality characteristic. If I used the standard AirParticulateDensity instead, the history graph is not working anymore.

I have no real "Eve Room" and can't help. But most likely there will be differences. On some screenshots you can see that stars appear even in the Eve app instead of the quality terms.

@tobekas
Copy link
Author

tobekas commented Apr 6, 2019

... and the units are different:
Custom: ppm (max. 5000)
Standard: µg/m^3 (max. 1000)

It is also surprising that the standard AirParticulateDensity is not an optional characteristic for service AirQualitySensor.

Anyway, this issue is solved. Thank you!

@ebaauw ebaauw closed this as completed Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants