Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require development dependencies #5

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Require development dependencies #5

merged 1 commit into from
Feb 1, 2019

Conversation

luk4s
Copy link
Contributor

@luk4s luk4s commented Jan 31, 2019

Because when RYS is used for clean Redmine, there is no require of factory_bot or database_cleaner, so constants missing...

@luk4s luk4s requested a review from ondra-m January 31, 2019 11:17
ondra-m
ondra-m suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@ondra-m ondra-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the branch to the devel. Master is still used for stable packages.

@luk4s luk4s changed the base branch from master to devel January 31, 2019 18:08
@ondra-m ondra-m merged commit b0aeea1 into devel Feb 1, 2019
@ondra-m ondra-m deleted the require_development_dependencies branch February 1, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondra-m ondra-m ondra-m approved these changes

Assignees

@ondra-m ondra-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luk4s @ondra-m