Use more robust mechanism for unsetting environment variables #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Oct 16, 2024
easybuild/tools/run.py
Outdated
| @@ -217,8 +217,10 @@ def create_cmd_scripts(cmd_str, work_dir, env, tmpdir, out_file, err_file): | |||
| with open(env_fp, 'w') as fid: | |||
| # unset all environment variables in current environment first to start from a clean slate; | |||
| # we need to be careful to filter out functions definitions, so first undefine those | |||
| fid.write("unset -f $(env | grep '%=' | cut -f1 -d'%' | sed 's/BASH_FUNC_//g')\n") | |||
| fid.write("unset $(env | cut -f1 -d=)\n") | |||
| fid.write("for var in $(compgen -e); do\n unset \"$var\"\ndone\n") | |||
There was a problem hiding this comment.
@Micket This is really hard to read, how about this instead? (and then similar below)
fid.write('\n'.join([
'for var in $(compgen -e); do',
' unset "$var"',
'done',
]) + '\n')Parsing the output of "env" can be fragile for certain complex environment. Using compgen should be safer.
…of environment more robust
|
Did the test just hang and die? There is no output in the CI, just a red mark that it failed the tests for one particular python version. |
For which commit? For last commit, it's all green... |
boegel
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing the output of "env" can be fragile for certain complex environment.
Using compgen should be safer.