-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate run_cmd
and run_cmd_qa
& co, move them to easybuild._deprecated
module
#4433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run_cmd
and run_cmd_qa
& co, move them to easybuild._deprecated
module (WIP)run_cmd
and run_cmd_qa
& co, move them to easybuild._deprecated
module (WIP)
run_cmd
and run_cmd_qa
& co, move them to easybuild._deprecated
module (WIP)run_cmd
and run_cmd_qa
& co, move them to easybuild._deprecated
module
…eprecated parse_log_for_error (used by run_cmd + run_cmd_qa)
b4dd005
to
72704a7
Compare
branfosj
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code in
easybuild/_deprecated.py
was cut fromeasybuild/tools/run.py
without changes, with one small exception: therun_cmd_cache
decorator was changed to only considerinp
, notstdin
(since the latter is specific torun_shell_cmd
).WIP because more work is needed here once the implementation of
run_shell_cmd
is complete (incl. support forasynchronous
andqa_patterns
+qa_wait_patterns
):easybuild._deprecated
, likerun_cmd_qa
, etc.;self.allow_deprecated_behaviour()
in tests where needed, or catch deprecation warning to ignore it;