fix use of locate in check_os_dependency
#4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`locate` may not set an error exit code when it does not find a dependency so the function may wronly succeed. Use the `-c` option to get a number of matches and check that this is more than zero (and an integer) in addition to the exit code. Fixes easybuilders#4165
boegel
changed the title
check_os_dependencylocate in check_os_dependency
|
@Flamefire Can we enhance the tests for |
|
I don't think so. It depends on how the OS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locatemay not set an error exit code when it does not find a dependency so the function may wrongly succeed.Use the
-coption to get a number of matches and check that this is more than zero (and an integer) in addition to the exit code.Fixes #4165