Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly identify Apple Silicon M1 as Arm 64-bit by also considering arm64 next to aarch64 #4014

Merged
merged 1 commit into from
May 30, 2022
Merged

correctly identify Apple Silicon M1 as Arm 64-bit by also considering arm64 next to aarch64 #4014

merged 1 commit into from
May 30, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented May 30, 2022

No description provided.

@boegel boegel added the bug fix label May 30, 2022
@boegel boegel added this to the 4.5.5 milestone May 30, 2022
@boegel boegel mentioned this pull request May 30, 2022
Merged
@ocaisa
Copy link
Member

ocaisa commented May 30, 2022

Code looks ok, I have no way of checking this though so I'm going on faith alone

@ocaisa ocaisa merged commit acc8dec into easybuilders:develop May 30, 2022
@boegel boegel deleted the arm64 branch May 30, 2022 13:46
@boegel
Copy link
Member Author

boegel commented May 30, 2022

Just to clarify: without this change, I was getting AArch32 as a result from get_cpu_architecture on Apple M1:

$ python3 -c 'from easybuild.tools.systemtools import get_cpu_architecture; print(get_cpu_architecture())'
AArch32

with these changes, I'm getting AArch64, as it should be:

$ python3 -c 'from easybuild.tools.systemtools import get_cpu_architecture; print(get_cpu_architecture())'
AArch64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.5.5
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @ocaisa