-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nvompi toolchain definition (NVHPC + OpenMPI) #3969
add nvompi toolchain definition (NVHPC + OpenMPI) #3969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
easybuild/toolchains/nvompi.py
Outdated
EasyBuild support for nvompi compiler toolchain (NVHPC + Open MPI). | ||
|
||
:author: Maxime Boissonneault (Universite Laval, Calcul Quebec, Compute Canada) | ||
:author: Bart Oldeman (McGill University, Calcul Quebec, Compute Canada) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robert-mijakovic Please change author to yourself?
@robert-mijakovic This looks good to merge, just need to address the comment |
Done. Thanks for reminding me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(created using
eb --new-pr
)