Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly determine commit status in --merge-pr #3406

Merged
merged 1 commit into from
Aug 17, 2020
Merged

correctly determine commit status in --merge-pr #3406

merged 1 commit into from
Aug 17, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 15, 2020

fixes #3405

@boegel boegel added the bug fix label Aug 15, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Aug 15, 2020
@boegel boegel mentioned this pull request Aug 15, 2020
Closed
@boegel boegel closed this Aug 15, 2020
@boegel boegel reopened this Aug 15, 2020
@boegel
Copy link
Member Author

boegel commented Aug 16, 2020

waves fist at Travis CI

@boegel boegel closed this Aug 16, 2020
@boegel boegel reopened this Aug 16, 2020
@boegel boegel closed this Aug 16, 2020
@boegel boegel reopened this Aug 16, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 16, 2020
@boegel boegel closed this Aug 16, 2020
@boegel boegel reopened this Aug 16, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 16, 2020
@boegel boegel force-pushed the det_commit_status_travis_github_actions branch from ab8cbd1 to 479cf33 Compare August 16, 2020 16:43
@easybuilders easybuilders deleted a comment from boegelbot Aug 16, 2020
@smoors
Copy link
Contributor

smoors commented Aug 16, 2020

tested, seems to work well

@easybuilders easybuilders deleted a comment from boegelbot Aug 17, 2020
akesandgren
akesandgren approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit f8e4958 into easybuilders:develop Aug 17, 2020
@boegel boegel deleted the det_commit_status_travis_github_actions branch August 17, 2020 12:08
boegel added a commit to boegel/boegelbot that referenced this pull request Aug 17, 2020
@boegel
use fetch_pr_data from easybuild.tools.github (requires easybuilders/…
779c4f6 
…easybuild-framework#3406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

--merge-pr refuses to merge easyconfig PRs because test suite is "pending"
3 participants
@boegel @smoors @akesandgren