Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create symlink from lib64 to lib subdir in installation directories to avoid that GCC prefers /lib64 system directories #3401

Merged
merged 3 commits into from
Aug 18, 2020
Merged

create symlink from lib64 to lib subdir in installation directories to avoid that GCC prefers /lib64 system directories #3401

merged 3 commits into from
Aug 18, 2020

Conversation

Flamefire
Copy link
Contributor

This avoids using the system libs from /lib64 instead of libs from LIBRARY_PATH
Fixes easybuilders/easybuild-easyconfigs#5776 but needs a rebuild of the affected modules

@Flamefire
Copy link
Contributor Author

Ok this seems to conflict with the test for disable-lib64-fallback-sanity-check. How to proceed?

boegel
boegel requested changes Aug 13, 2020
View reviewed changes
easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
@boegel
Copy link
Member

boegel commented Aug 13, 2020

Ok this seems to conflict with the test for disable-lib64-fallback-sanity-check. How to proceed?

We could add a configuration option like --symlink-lib-lib64 which is enabled by default, and then use --disable-symlink-lib-lib64 in the test for --disable-lib64-fallback-sanity-check?

@boegel boegel changed the title Create symlink from lib64 to lib directory create symlink from lib64 to lib subdir in installation directories to aoivd that GCC prefers /lib64 system directories Aug 13, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Aug 13, 2020
@boegel boegel mentioned this pull request Aug 13, 2020
Closed
@Flamefire
Copy link
Contributor Author

Ok added --lib64-lib-symlink option in 6ccd097 to make it show up next to the other lib64 option

@Flamefire Flamefire mentioned this pull request Aug 13, 2020
Merged
6 tasks
@Flamefire
Create symlink from lib64 to lib directory
6dcc3d8 
This avoids using the system libs from /lib64 instead of libs from LIBRARY_PATH
Fixes easybuilders/easybuild-easyconfigs#5776 but needs a rebuild of the affected modules
@Flamefire
Add lib64-lib-symlink option
ae4e518
@Flamefire
Copy link
Contributor Author

Fixed the merge conflict.

@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@boegel boegel changed the title create symlink from lib64 to lib subdir in installation directories to aoivd that GCC prefers /lib64 system directories create symlink from lib64 to lib subdir in installation directories to avoid that GCC prefers /lib64 system directories Aug 18, 2020
boegel
boegel requested changes Aug 18, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but is missing a test, fixed with Flamefire#4

@Flamefire
Copy link
Contributor Author

Well it was tested although hidden in another test: https://github.com/easybuilders/easybuild-framework/pull/3401/files#diff-ce4ad0ca611df220e49671774fa169a9R1982

But yours is better of course, thanks!

@boegel boegel merged commit 7271d11 into easybuilders:develop Aug 18, 2020
@Flamefire Flamefire deleted the lib64symlink branch August 19, 2020 08:15
@Flamefire Flamefire mentioned this pull request Sep 16, 2020
Open
@branfosj branfosj mentioned this pull request Oct 30, 2020
Merged
@boegel boegel mentioned this pull request Jan 20, 2021
Closed
@mboisson
Copy link
Contributor

mboisson commented Feb 3, 2021

Could this be made to be a symlink to a relative path, rather than an absolute path ?

@boegel
Copy link
Member

boegel commented Feb 3, 2021

@mboisson Please open an issue on this, we can't possibly keep up with change requests in merged PRs...

It makes total sense to make this a relative symlink, of course.

@mboisson mboisson mentioned this pull request Feb 3, 2021
Closed
@branfosj branfosj mentioned this pull request Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix change
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

GCC prefers /lib64 libs over $LIBRARY_PATH from EasyBuild modules (!)
3 participants
@Flamefire @boegel @mboisson