Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing Python dependency for HPDBSCAN to fix unresolved %(pyshortver)s template #15694

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jun 15, 2022

(created using eb --new-pr)

Without this fix, the Python bindings are being installed in a literal lib/python%(pyshortver)s/site-packages subdirectory (which is not caught by the sanity check, because %(pyshortver)s is consistently remaining unresolved...)

@branfosj branfosj added this to the next release (4.5.6?) milestone Jun 15, 2022
@boegel
Copy link
Member Author

boegel commented Jun 15, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2680.swalot.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/899717a0ec9d428b550100e68c5588c2 for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 15, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15694 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15694 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8724

Test results coming soon (I hope)...

- notification for comment with ID 1156468379 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d5bab378c77ed69110fd18032cc83093 for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 13 out of 13 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/ef29efc272c4442322039a616aa4e5fd for a full test report.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit ca56c42 into easybuilders:develop Jun 15, 2022
@boegel boegel deleted the 20220615145849_new_pr_HPDBSCAN20210826 branch June 15, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants