Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently enable usempi toolchain option in OSU-Micro-Benchmarks easyconfigs #15039

Merged
merged 17 commits into from
Feb 23, 2022

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Feb 23, 2022

No description provided.

@branfosj
Copy link
Member

Looking at the OSU easyconfigs, we have two separate setups:

  1. Using configopts = 'CC="$MPICC" CXX="$MPICC"'
  2. Using toolchainopts = {'usempi': True}

If we, instead, switch them all to use method 2 then this automatically sets CC and CXX as required?

@ocaisa
Copy link
Member Author

ocaisa commented Feb 23, 2022

I'm on board, I also noticed that when creating #15018
I'll update this and there as well.

@ocaisa ocaisa changed the title Fix typo in OSU-Micro-Benchmarks-5.7.1-gompi-2021a-CUDA-11.3.1.eb Fix typos in OSU-Micro-Benchmarks easyconfigs Feb 23, 2022
@ocaisa
Copy link
Member Author

ocaisa commented Feb 23, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=15039 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15039 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8178

Test results coming soon (I hope)...

- notification for comment with ID 1048858355 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 16 out of 16 (16 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0f6d5225944ca69fcb9cecec8aa38f99 for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added the bug fix label Feb 23, 2022
@smoors smoors added this to the next release (4.5.4?) milestone Feb 23, 2022
@smoors
Copy link
Contributor

smoors commented Feb 23, 2022

Test report by @smoors
FAILED
Build succeeded for 21 out of 24 (16 easyconfigs in total)
node250.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz (broadwell), 1 x NVIDIA Tesla P100-PCIE-16GB, 470.82.01, Python 2.7.5
See https://gist.github.com/5ddc192a2705065ab689a7b8931bad99 for a full test report.

@smoors
Copy link
Contributor

smoors commented Feb 23, 2022

the failures are because our cluster does not currently support the iimpic toolchain.

@smoors
Copy link
Contributor

smoors commented Feb 23, 2022

Going in, thanks @ocaisa!

@smoors smoors merged commit 8d83e53 into develop Feb 23, 2022
@boegel boegel deleted the ocaisa-patch-2 branch February 27, 2022 14:33
@boegel boegel changed the title Fix typos in OSU-Micro-Benchmarks easyconfigs consistently enable usempi toolchain option in OSU-Micro-Benchmarks easyconfigs Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants