-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2020b,fosscuda/2020b] AlphaFold v2.1.2 w/ Python 3.8.6 #14905
{bio}[foss/2020b,fosscuda/2020b] AlphaFold v2.1.2 w/ Python 3.8.6 #14905
Conversation
…2-fosscuda-2020b.eb and patches: AlphaFold-2.1.2_data-dep-paths.patch
easybuild/easyconfigs/a/AlphaFold/AlphaFold-2.1.2-fosscuda-2020b.eb
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Test report by @boegel |
Test for
Same problem happened with AlphaFold 2.1.1 in #14500 on our A100 system, so I guess I should try and figure this out... |
Test report by @boegel |
Test report by @boegel |
@boegel on your build systems does There are two tests run - no_relax (/unrelaxed) and relax (/relaxed). The extra file that exists is created in the relaxed test, which is the second one run, so it should not exist before that test is run. However, there is no sign that the test directory is cleared between tests. So, if your system is not cleaning up the temporary directory between builds, the old files will still be there. You can test this with the following - using import os
from absl.testing import absltest
class RunAlphafoldTest(absltest.TestCase):
def test_me(self):
out_dir = absltest.get_default_test_tmpdir()
print('before write', os.listdir(out_dir))
with open(os.path.join(out_dir, 'file'), 'w') as f:
f.write('hello world')
print('after write', os.listdir(out_dir))
self.assertEqual(1, 1)
if __name__ == '__main__':
absltest.main() Then run this twice:
Note how |
Oh, now I understand why @boegel is seeing the issue and I am not. When I test build AlphaFold I build the GPU and CPU versions separately on different systems. Kenneth always builds both at the same time. Kenneth will be seeing the issue because the temp directory is created in the first build (CPU) and still there for the second (GPU). |
I've filed google-deepmind/alphafold#365 and I've PR-ed adding the patch to the existing 2.1.x AlphaFold easyconfig in #14989 |
I think the next step here is to also use the patch from #14989 here. @ThomasHoffmann77 Are you up for making that extra change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel Yes
@ThomasHoffmann77 I've made suggested changes to add the relevant patch to both easyconfigs
easybuild/easyconfigs/a/AlphaFold/AlphaFold-2.1.2-foss-2020b-TensorFlow-2.5.0.eb
Show resolved
Hide resolved
easybuild/easyconfigs/a/AlphaFold/AlphaFold-2.1.2-foss-2020b-TensorFlow-2.5.0.eb
Show resolved
Hide resolved
easybuild/easyconfigs/a/AlphaFold/AlphaFold-2.1.2-fosscuda-2020b-TensorFlow-2.5.0.eb
Show resolved
Hide resolved
easybuild/easyconfigs/a/AlphaFold/AlphaFold-2.1.2-fosscuda-2020b-TensorFlow-2.5.0.eb
Show resolved
Hide resolved
…0b-TensorFlow-2.5.0.eb Co-authored-by: Simon Branford <[email protected]>
…0b-TensorFlow-2.5.0.eb Co-authored-by: Simon Branford <[email protected]>
…ensorFlow-2.5.0.eb Co-authored-by: Simon Branford <[email protected]>
…ensorFlow-2.5.0.eb Co-authored-by: Simon Branford <[email protected]>
Test report by @boegel |
Test report by @boegel |
easybuild/easyconfigs/a/AlphaFold/AlphaFold-2.1.2-foss-2020b-TensorFlow-2.5.0.eb
Outdated
Show resolved
Hide resolved
…2.1.2 easyconfigs using foss(cuda)/2020b toolchain
minor style tweaks + set missing environment variables for AlphaFold 2.1.2 easyconfigs using foss(cuda)/2020b toolchain
Test report by @boegel |
Test report by @boegel |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1043295718 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @ThomasHoffmann77! |
…2-fosscuda-2020b.eb and patches: AlphaFold-2.1.2_data-dep-paths.patch