add CI check for -DCMAKE_BUILD_TYPE, should use build_type instead
#14008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Flamefire
force-pushed
the
ci_check_cmake_build_type
branch
from
b2b3561 to
d2eda9f
Compare
|
Rebased onto develop resolving the conflicts. |
Flamefire
force-pushed
the
ci_check_cmake_build_type
branch
from
d2eda9f to
5c9b9ee
Compare
branfosj
reviewed
Jul 2, 2023
…asyconfigs into ci_check_cmake_build_type
branfosj
approved these changes
Jul 2, 2023
boegel
changed the title
build_type instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that
-DCMAKE_BUILD_TYPEis no longer used in configopts, see #13384and that
Releaseis not used as thebuild_typeas it is already the defaultAlso a change to only parse changed ECs when running the PR tests only instead of all ECs (which takes ages). This leverages the caching behavior of EasyConfigTest._parsed_easyconfigs so when later parsing all ECs the already parsed ones are not reparsed.
This makes running the PR tests only very fast