Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable debuginfod for elfutils to minimize required dependencies #13034

Merged

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jun 3, 2021

(created using eb --new-pr)

Our builds of elfutils are rather bloated with an httpd server and a sqlite database that are only needed for debuginfod, a server/client solution for debugging. I think that it is preferable to remove such debug features by default and reduce the number of dependencies of elfutils.

If anybody needs those debug tools we could make a more complete solution by having an extra easyconfig of elfutils (eg -debug versionsuffix) with debuginfod that also has Valgrind.

@lexming lexming added the change label Jun 3, 2021
@lexming lexming added this to the 4.x milestone Jun 3, 2021
@lexming
Copy link
Contributor Author

lexming commented Jun 3, 2021

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
node377.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/ef0dc3f4001c472815c9c575630e9303 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 6, 2021

@boegelbot please test @ generoso
EB_ARGS="Clang-11.0.1-gcccuda-2020b.eb elfutils-0.182-GCCcore-9.3.0.eb elfutils-0.183-GCCcore-10.2.0.eb --cuda-compute-capabilities 7.0"
CORE_CNT=16

@easybuilders easybuilders deleted a comment from boegelbot Jun 6, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 6, 2021
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13034 EB_ARGS="Clang-11.0.1-gcccuda-2020b.eb elfutils-0.182-GCCcore-9.3.0.eb elfutils-0.183-GCCcore-10.2.0.eb --cuda-compute-capabilities 7.0" /apps/slurm/default/bin/sbatch --job-name test_PR_13034 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17376

Test results coming soon (I hope)...

- notification for comment with ID 855397253 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2ad9817296fc93368f122028dcc31b46 for a full test report.

@boegel boegel changed the title disable debuginfod from elfutils disable debuginfod for elfutils to minimize required dependencies Jun 6, 2021
@boegel
Copy link
Member

boegel commented Jun 6, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
node3100.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/5b7f21b167c6fdedc2c71ed5e07346c2 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jun 6, 2021

Going in, thanks @lexming!

@boegel boegel merged commit 8e48b58 into easybuilders:develop Jun 6, 2021
@lexming lexming deleted the 20210604000619_new_pr_elfutils0182 branch June 7, 2021 07:47
@boegel boegel modified the milestones: 4.x, next release (4.4.1) Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants