-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{compiler}[GCCcore/10.2.0,gcccuda/2020b] AOMP v13.0.2 #12909
Conversation
This is an updated version of the PR easybuilders#12018. This PR updates the version to `13.0-2`. In addition this PR adds an improved patch which should force the built modules to pick up the EasyBuild installed version of `gcc`. This module requires the `aomp.py` EasyBlock to build.
@migueldiascosta Could you test if the patch included here is enough to avoid the problems of #12018 and confusion between which |
Test report by @migueldiascosta |
Test report by @migueldiascosta |
@nordmoen the earlier problems are solved, but the symbolic link creates problems when reinstalling ( (note: the tests above don't include the cuda variant) |
I tried to patch this out, but it immediately fails in other parts of the build. Any tips on workarounds? |
@nordmoen so, is it the |
It seems to be the |
@migueldiascosta I updated the EasyBlock which seems to work locally. Could you test again when you have the time? |
Test report by @migueldiascosta |
Now that the |
You can do that by doing, "eb --sync-pr-with-develop 12909" |
Thanks @akesandgren ! |
@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2464" |
Test report by @smoors |
@smoors To build the AOMP module with CUDA support you have to supply |
Test report by @smoors |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 859735482 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @nordmoen! |
This is an updated version of the PR #12018. This PR updates the version
to
13.0-2
. In addition this PR adds an improved patch which shouldforce the built modules to pick up the EasyBuild installed version of
gcc
.This module requires the
aomp.py
EasyBlock to build.