Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{compiler}[GCCcore/10.2.0,gcccuda/2020b] AOMP v13.0.2 #12909

Merged
merged 8 commits into from
Jun 11, 2021

Conversation

nordmoen
Copy link
Contributor

@nordmoen nordmoen commented May 20, 2021

This is an updated version of the PR #12018. This PR updates the version
to 13.0-2. In addition this PR adds an improved patch which should
force the built modules to pick up the EasyBuild installed version of
gcc.

This module requires the aomp.py EasyBlock to build.

Jørgen Nordmoen added 2 commits May 20, 2021 14:49
This is an updated version of the PR easybuilders#12018. This PR updates the version
to `13.0-2`. In addition this PR adds an improved patch which should
force the built modules to pick up the EasyBuild installed version of
`gcc`.

This module requires the `aomp.py` EasyBlock to build.
@nordmoen
Copy link
Contributor Author

@migueldiascosta Could you test if the patch included here is enough to avoid the problems of #12018 and confusion between which gcc is picked up with LLVM?

@branfosj branfosj added the new label May 20, 2021
@branfosj branfosj added this to the 4.x milestone May 20, 2021
@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2435
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/399377ad4ec4ba947777c035a8b71d3f for a full test report.

@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2435
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/2f15bdfaf84f4b90388ab093122777d9 for a full test report.

@migueldiascosta
Copy link
Member

migueldiascosta commented May 21, 2021

@nordmoen the earlier problems are solved, but the symbolic link creates problems when reinstalling ( OSError('Cannot call rmtree on a symbolic link',))

(note: the tests above don't include the cuda variant)

@nordmoen
Copy link
Contributor Author

@nordmoen the earlier problems are solved, but the symbolic link creates problems when reinstalling ( OSError('Cannot call rmtree on a symbolic link',))

(note: the tests above don't include the cuda variant)

I tried to patch this out, but it immediately fails in other parts of the build. Any tips on workarounds?

@migueldiascosta
Copy link
Member

@nordmoen so, is it the build_aomp.sh script that creates the link? maybe the easyblock can then cleanup by removing the link and renaming the directory?

@nordmoen
Copy link
Contributor Author

@nordmoen so, is it the build_aomp.sh script that creates the link? maybe the easyblock can then cleanup by removing the link and renaming the directory?

It seems to be the build_project.sh script which is called from build_aomp.sh (and is required). I will look into removing it in the EasyBlock.

@nordmoen
Copy link
Contributor Author

@migueldiascosta I updated the EasyBlock which seems to work locally. Could you test again when you have the time?

@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2435
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/51c93914c3f152bc00fe8364ca2a0611 for a full test report.

@nordmoen
Copy link
Contributor Author

nordmoen commented Jun 8, 2021

Now that the aomp.py easyblock has been merged, could someone re-run these checks?

@akesandgren
Copy link
Contributor

You can do that by doing, "eb --sync-pr-with-develop 12909"

@nordmoen
Copy link
Contributor Author

nordmoen commented Jun 8, 2021

You can do that by doing, "eb --sync-pr-with-develop 12909"

Thanks @akesandgren !

@easybuilders easybuilders deleted a comment from boegelbot Jun 8, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 8, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 8, 2021
@boegel boegel changed the title {compiler}[AOMP/13.0-2] Add updated AOMP compiler module {compiler}[GCCcore/10.2.0,gcccuda/2020b] AOMP v13.0.2 Jun 8, 2021
@smoors
Copy link
Contributor

smoors commented Jun 11, 2021

@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2464"

@smoors
Copy link
Contributor

smoors commented Jun 11, 2021

Test report by @smoors
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2464
FAILED
Build succeeded for 4 out of 5 (2 easyconfigs in total)
node153.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz (ivybridge), Python 2.7.5
See https://gist.github.com/f278102f87f3c6c272fca19f476c1634 for a full test report.

@nordmoen
Copy link
Contributor Author

Test report by @smoors
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2464
FAILED
Build succeeded for 4 out of 5 (2 easyconfigs in total)
node153.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz (ivybridge), Python 2.7.5
See https://gist.github.com/f278102f87f3c6c272fca19f476c1634 for a full test report.

@smoors To build the AOMP module with CUDA support you have to supply --cuda-compute-capabilities

@smoors
Copy link
Contributor

smoors commented Jun 11, 2021

Test report by @smoors
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2464
SUCCESS
Build succeeded for 5 out of 5 (2 easyconfigs in total)
node153.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz (ivybridge), Python 2.7.5
See https://gist.github.com/f30ba6582420c1a43b4120611657b118 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jun 11, 2021
@boegel
Copy link
Member

boegel commented Jun 11, 2021

@boegelbot please test @ generoso
EB_ARGS="--cuda-compute-capabilities 7.0"
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12909 EB_ARGS="--cuda-compute-capabilities 7.0" /apps/slurm/default/bin/sbatch --job-name test_PR_12909 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17432

Test results coming soon (I hope)...

- notification for comment with ID 859735482 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f53aa7b664f83907e22675af0adfbb13 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 11, 2021

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (2 easyconfigs in total)
node3301.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/9280af96a8f88c7f5c1719c2bb0d7ef3 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jun 11, 2021

Going in, thanks @nordmoen!

@boegel boegel merged commit 8d9105e into easybuilders:develop Jun 11, 2021
@boegel boegel modified the milestones: 4.x, next release (4.4.1) Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants