Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with develop (20250120) #3564

Merged
merged 6 commits into from
Jan 20, 2025
Merged

sync with develop (20250120) #3564

merged 6 commits into from
Jan 20, 2025

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 20, 2025

No description provided.

@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Jan 20, 2025
@boegel boegel added this to the 5.0 milestone Jan 20, 2025
@boegel
Copy link
Member Author

boegel commented Jan 20, 2025

@lexming Will this be fixed in:

   File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyblock.py", line 1670, in make_module_req
    self.module_load_environment.update(self.make_module_req_guess())
  File "/home/runner/work/easybuild-easyblocks/easybuild-easyblocks/easybuild/easyblocks/generic/rpm.py", line 242, in make_module_req_guess
    'PATH': guesses.get('PATH', []) + ['usr/bin', 'sbin', 'usr/sbin'],
TypeError: unsupported operand type(s) for +: 'ModuleEnvironmentVariable' and 'list'

@lexming
Copy link
Contributor

lexming commented Jan 20, 2025

@boegel yes, it is fixed in that PR. I didn't add support to do something like the following, but it's something we can consider

self.module_load_environment.PATH + ['usr/bin', 'sbin', 'usr/sbin']

@boegel boegel merged commit 94912db into easybuilders:5.0.x Jan 20, 2025
13 of 19 checks passed
@boegel
Copy link
Member Author

boegel commented Jan 20, 2025

Note: this got merged via #3561 (but no changes were made compared to what's already merged into develop, other than fixing trivial merge conflicts in updates to copyright header in 1726336

@boegel boegel added the update label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants