Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance TensorFlow easyblock to avoid use of -mcpu=native for XNNPACK component when building on aarch64 #3011

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 3, 2023

(created using eb --new-pr)
fixes easybuilders/easybuild-easyconfigs#18899

@boegel boegel added bug fix EESSI Related to EESSI project labels Oct 3, 2023
@boegel boegel added this to the 4.x milestone Oct 3, 2023
@boegel boegel changed the title enhance TensorFlow easyblock to avoid use of -mcpu=native for XNNPACK component when building on aarch64 enhance TensorFlow easyblock to avoid use of -mcpu=native for XNNPACK component when building on aarch64 Oct 3, 2023
@boegel boegel modified the milestones: 4.x, next release (4.8.2?) Oct 11, 2023
@akesandgren
Copy link
Contributor

Any test reports coming up for this?

@boegel
Copy link
Member Author

boegel commented Oct 25, 2023

@akesandgren Yes, but there's other fixes needed for recent TensorFlow versions on aarch64, so this needs to be paired with easyconfig PRs.

I guess we could go ahead and merge this already, since it clearly doesn't hurt on x86_64...

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit f1392d6 into easybuilders:develop Oct 25, 2023
@boegel boegel deleted the 20231003090540_new_pr_tensorflow branch November 8, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing build of recent TensorFlow easyconfigs on AWS Graviton3 (aarch64/neoverse_v1)
2 participants