-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance Gurobi easyblock to allow using $EB_GUROBI_LICENSE_FILE environment variable #2926
enhance Gurobi easyblock to allow using $EB_GUROBI_LICENSE_FILE environment variable #2926
Conversation
erh.. this got troublesome. The old code has the checks for But now the init step requires the existance of a license file, which breaks the unit tests somehow. I guess i'll just move those checks to the install step. The sanity check already includes a final check as well, so it's all pretty overkill anyway. I moved it into the dir, install step and only when copying is attempted, otherwise, the install step wouldn't care whether the file exists or not. The sanity check takes care of the final check anyway. |
This comment was marked as outdated.
This comment was marked as outdated.
Test report by @jfgrimm Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Micket! |
(created using
eb --new-pr
)