Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance Gurobi easyblock to allow using $EB_GUROBI_LICENSE_FILE environment variable #2926

Merged
merged 4 commits into from
May 4, 2023

Conversation

Micket
Copy link
Contributor

@Micket Micket commented May 3, 2023

(created using eb --new-pr)

@Micket
Copy link
Contributor Author

Micket commented May 3, 2023

erh.. this got troublesome.

The old code has the checks for self.cfg['license_file'] in install_step, so it was broken for --module-only since self.license_file is in that case never assigned.

But now the init step requires the existance of a license file, which breaks the unit tests somehow. I guess i'll just move those checks to the install step. The sanity check already includes a final check as well, so it's all pretty overkill anyway. I moved it into the dir, install step and only when copying is attempted, otherwise, the install step wouldn't care whether the file exists or not. The sanity check takes care of the final check anyway.

@jfgrimm

This comment was marked as outdated.

@jfgrimm jfgrimm added this to the 4.x milestone May 4, 2023
@jfgrimm
Copy link
Member

jfgrimm commented May 4, 2023

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS Gurobi-9.0.0.eb
  • SUCCESS Gurobi-9.0.3-GCCcore-10.2.0.eb
  • SUCCESS Gurobi-9.1.2.eb
  • SUCCESS Gurobi-9.5.0-GCCcore-10.3.0.eb
  • SUCCESS Gurobi-9.5.2-GCCcore-11.3.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
himem02.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/jfgrimm/3b7a02c7aa84d9e39171566a47712a18 for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Member

jfgrimm commented May 4, 2023

Going in, thanks @Micket!

@jfgrimm jfgrimm merged commit e600788 into easybuilders:develop May 4, 2023
@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.7.2) May 4, 2023
@Micket Micket deleted the 20230504001600_new_pr_gurobi branch May 4, 2023 14:44
@boegel boegel changed the title Allow gurobi to use EB_GUROBI_LICENSE_FILE environment variable enhance Gurobi easyblock to allow using $EB_GUROBI_LICENSE_FILE environment variable May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants