Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check commands to Clang easyblock and print warning for missing ncurses #2193

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

Flamefire
Copy link
Contributor

Loading the clang module and trying to run it makes it error with a missing ncurses lib which isn't currently detected.

I added sanity check commands and a warning to avoid this.

Question: Do we want this here and update the ECs or repeat the sanity check commands in every EC to avoid breaking existing ones?

@migueldiascosta
Copy link
Member

migueldiascosta commented Oct 6, 2020

well, in systems where the existing ECs work because ncurses is installed at the system level, this doesn't break them, so it will only break installations that wouldn't work anyway... I'd say option a...

@Flamefire
Copy link
Contributor Author

I updated many Clang ECs to include the ncurses dependency.

Note that ncurses is autodetected and as we have cmake as a build dependency for clang it gets detected and used. I guess the issue didn't show because the Clang module was mostly loaded with something else (e.g. CMake) which loads ncurses.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @Flamefire!

@migueldiascosta migueldiascosta merged commit d6a70b9 into easybuilders:develop Oct 8, 2020
@Flamefire Flamefire deleted the clang-ncurses branch October 8, 2020 07:34
@boegel boegel changed the title Add sanity check commands to clang and print warning for missing ncurses Add sanity check commands to Clang easyblock and print warning for missing ncurses Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants