add support in NAMD easyblock to pass additional C++ compiler options for building Charm++ component with + wrap them in single quotes #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for building Charm++ component with
…s, to avoid trouble with '-fp-model source' being passed when building with Intel compilers
boegel
changed the title
|
just wondering, if the issue is specific to the g++ version, why not checking that and adding are you anticipating the need to pass other |
|
@migueldiascosta I could, but i) I don't know which range of g++ versions the flag is required, ii) this problem will probably disappear in future NAMD versions (so the check in the easyblock would have to be both compiler and NAMD version specific, which seems a bit much). There may arise a use case for passing other C++ compiler flags to the |
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building NAMD 2.14 with
foss/2019borfoss/2020arequires passing-fpermissivewhen building Charm++, so we need a custom easyconfig parameter to allow for that...