Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for installation of pip & setuptools in Python 3.4+ #2108

Merged
merged 5 commits into from
Sep 1, 2020

Conversation

Flamefire
Copy link
Contributor

Python 3.4 comes with pip and setuptools. This is even required to install (the newer) pip in the EC so not having it is an error.

Furthermore installation of pip/setuptools fails if a distutils user config sets the prefix to a different directory as that would be where pip is then installed. See easybuilders/easybuild-easyconfigs#11009
Hence check for that and report a (verbose) warning.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to take this for a test drive

easybuild/easyblocks/p/python.py Outdated Show resolved Hide resolved
easybuild/easyblocks/p/python.py Outdated Show resolved Hide resolved
@boegel boegel added this to the next release (4.2.3?) milestone Aug 5, 2020
easybuild/easyblocks/p/python.py Outdated Show resolved Hide resolved
easybuild/easyblocks/p/python.py Show resolved Hide resolved
easybuild/easyblocks/p/python.py Show resolved Hide resolved
@hound hound bot deleted a comment from Flamefire Aug 9, 2020
@boegel boegel changed the title [Python] Handle installation of pip&setuptools on Python 3.4+ handle installation of pip & setuptools in Python 3.4+ Aug 24, 2020
@Flamefire
Copy link
Contributor Author

@lexming @ocaisa Can this be merged? Would be great to have it in the upcoming release

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on the install to finish to confirm the additional sanity checks are used

@ocaisa
Copy link
Member

ocaisa commented Sep 1, 2020

Going in, thanks @Flamefire

@ocaisa ocaisa merged commit aa3683d into easybuilders:develop Sep 1, 2020
@Flamefire Flamefire deleted the python-pip branch September 1, 2020 15:29
@boegel boegel changed the title handle installation of pip & setuptools in Python 3.4+ check for installation of pip & setuptools in Python 3.4+ Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants