Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom easyblock for STAR-CCM+ #1613

Merged
merged 5 commits into from
Jun 10, 2022
Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 10, 2019

No description provided.

@boegel boegel added the new label Jan 10, 2019
@boegel boegel added this to the 3.8.1 milestone Jan 10, 2019
@boegel boegel modified the milestones: 3.8.1, 3.x Jan 10, 2019
easybuild/easyblocks/s/star_ccm.py Show resolved Hide resolved
if len(cands) == 1:
install_script = cands[0]

env.setvar('CHECK_DISK_SPACE', 'OFF')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's neat

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and it gets better...

I just spent a couple of hours figuring out why the install script for STAR-CCM+ 16.06.008 was exiting with a non-zero exit code, with zero output.

After finding the log file (buried in $EBROOTSTARMINCCMPLUS/16.06.008/STAR-CCM+16.06.008/STAR-CCM+16.06.008_InstallLog.log (yes, the version subdir is there twice...), and mostly seeing Status: SUCCESSFUL, I was even more confused.

There was one Status: ERROR though, in the disk space check step....

So it seems that setting $CHECK_DISK_SPACE to OFF skips the disk space check, but also marks that step as failed, and hence the install script exists with a non-zero exit code. 🤦

So to fix: either don't set $CHECK_DISK_SPACE (if that works, I think it's only required when installing to an NFS mounted filesystem), or totally ignore the exit code of the install script and fully rely on the sanity check done by EasyBuild...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled this again, since it was causing trouble.

People can still resort to CHECK_DISK_SPACE=OFF eb ... when installing STAR-CCM+, if the disk space check is causing trouble.

easybuild/easyblocks/s/star_ccm.py Outdated Show resolved Hide resolved
easybuild/easyblocks/s/star_ccm.py Outdated Show resolved Hide resolved
easybuild/easyblocks/s/star_ccm.py Outdated Show resolved Hide resolved
easybuild/easyblocks/s/star_ccm.py Show resolved Hide resolved
@akesandgren
Copy link
Contributor

@boegel status of this one?

@boegel
Copy link
Member Author

boegel commented May 7, 2019

@akesandgren I don't have time to get back to this, for now.

@akesandgren
Copy link
Contributor

@boegel Would be useful if you could get back to this one soon...

@boegel boegel modified the milestones: 3.x, 4.x Feb 20, 2020
@boegel
Copy link
Member Author

boegel commented Jun 10, 2022

Hmm, looks like GitHub is a bit confused with the commit history... Those commits for the 4.5.5 are already in develop (see #2741).
Maybe another push (which is needed to fix the tests anyway) will resolve that.

(yep, it did)

@easybuilders easybuilders deleted a comment from boegelbot Jun 10, 2022
@wpoely86 wpoely86 merged commit fbbd7dc into easybuilders:develop Jun 10, 2022
@boegel boegel deleted the STAR_CCM branch June 10, 2022 11:14
@boegel boegel modified the milestones: 4.x, next release (4.5.6?) Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants