Skip to content

Commit

Permalink
Clarify the potential TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
Caspar van Leeuwen committed Jan 30, 2025
1 parent c3580a4 commit 980b045
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions easybuild/easyblocks/generic/binary.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ def post_install_step(self, rpath_dirs=None):
raise EasyBuildError("Failed to move staged install from %s to %s: %s",
staged_installdir, self.installdir, err)


# Check for patchelf if we plan to patch either rpath or interpreter
sysroot = build_option('sysroot')
add_library_path_to_rpath = self.toolchain.use_rpath and self.cfg.get('patch_rpaths', False)
Expand Down Expand Up @@ -338,7 +337,9 @@ def post_install_step(self, rpath_dirs=None):

curr_rpath, _ = run_cmd("patchelf --print-rpath %s" % path, simple=False, trace=False)
self.log.debug("RPATH for %s (after shrinking): %s" % (path, curr_rpath))
# TODO: make sure that after the shrink _SOME_ RPATH is left, otherwise the sanity check complains
# Potential TODO: should we make sure that after the shrink _SOME_ RPATH is left?
# Otherwise the sanity check may fail. However, our current case (Java) doesn't
# show this, so we'll postpone implementing this until we have a concrete use case.

except OSError as err:
raise EasyBuildError("Failed to patch RPATH or ELF interpreter section in binaries: %s", err)
Expand Down

0 comments on commit 980b045

Please sign in to comment.