Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin zarr & xarray #555

Merged
merged 12 commits into from
Jan 9, 2025
Merged

Unpin zarr & xarray #555

merged 12 commits into from
Jan 9, 2025

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jan 9, 2025

No description provided.

@dcherian dcherian requested review from mpiannucci and jhamman January 9, 2025 16:32
@mpiannucci
Copy link
Contributor

mpiannucci commented Jan 9, 2025 •
edited
Loading

We need to update the store to match the 3.0.0 api.

@mpiannucci
Copy link
Contributor

mpiannucci commented Jan 9, 2025 •
edited
Loading

The ByteRequest change doesn't line up with the rust version anymore

Last fetches up to the length of the chunk - n instead of fetching the last n chunks

Do we have a use case for the current functionality of this? Our ByteRangecould be changed if not

@mpiannucci
Copy link
Contributor

I changed icechunk to match. This is all good now i think, unless we want to add typed ByteRequest on our own end

@mpiannucci mpiannucci mentioned this pull request Jan 9, 2025
Open
@mpiannucci mpiannucci requested a review from paraseba January 9, 2025 18:28
paraseba
paraseba reviewed Jan 9, 2025
View reviewed changes
icechunk-python/pyproject.toml
@@ -16,7 +16,7 @@ classifiers = [
license = { text = "Apache-2.0" }
dynamic = ["version"]

dependencies = ["zarr==3.0.0rc2"]
dependencies = ["zarr>=3"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right way to specify it? should it be 3 but not for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you want "zarr>=3<4"?

cc @jhamman for input

@dcherian dcherian requested a review from paraseba January 9, 2025 19:28
@mpiannucci mpiannucci merged commit e4b6f00 into main Jan 9, 2025
4 checks passed
@mpiannucci mpiannucci deleted the unpin-xarray branch January 9, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpiannucci mpiannucci mpiannucci left review comments

@paraseba paraseba paraseba approved these changes

@jhamman jhamman Awaiting requested review from jhamman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcherian @mpiannucci @paraseba