Change libpico.a to build with PICO_XOSC_STARTUP_DELAY_MULTIPLIER=64 #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhalbert libpico.a is built by running this script in the tool https://github.com/earlephilhower/arduino-pico/blob/master/tools/libpico/make-libpico.sh . With this change, I think we could change the boot2 of qtpy from boot2_generic_03h_4_padded_checksum to boot2_w25q080_2_padded_checksum for fast running code, I will pull and check it out. |
|
@dhalbert the build script actually assumes that you've got a In any case, I'll pull this and give it a whirl and merge if all looks well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some samples of some Adafruit boards need a longer XOSC startup delay. We diagnosed this a while ago and PR'd a change to
pico-sdkthat adds a new compile-time constantPICO_XOSC_STARTUP_DELAY_MULTIPLIER, which allows lengthening the XOSC delay.arduino-picouses a single build oflibpico.afor all boards. To accomodate the Adafruit boards, this PR setsPICO_XOSC_STARTUP_DELAY_MULTIPLIER=64for the build, and provides a newly builtlibpico.a. The extra delay is still quite short, and shouldn't interfere with normal startup.I tested this on an Adafruit QT Py RP2040 that is known to need a longer startup time. THe board would not run after a power cycle or reset before this fix, and now it works fine.
See raspberrypi/pico-sdk#457 and raspberrypi/pico-sdk#401 for some background on this problem.
@earlephilhower I am not sure of your workflow for rebuilding
libpico.awithmake-libpico.sh. I builtlibpico.amanually withmake-libpico.shinside.arduino15using the lastest pico BSP, and then copied it into the commit for this PR. I had to do some manual fiddling with myPATHto make sure to use the compiler you include in the BSP. Themake-libpico.shscript assumes the correctarm-none-eabi-gccis onPATH, and also looks for tools insystem, though mysystemonly includessystem/placeholder. So I had to set things up manually to make the script work.Tagging @ladyada for FYI.