Log panics (flyteorg#109)

eapolinario · Apr 14, 2020 · d654cfb · d654cfb
1 parent 06fc60c
commit d654cfb
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/flytepropeller/pkg/controller/handler.go b/flytepropeller/pkg/controller/handler.go
@@ -115,6 +115,7 @@ func (p *Propeller) Handle(ctx context.Context, namespace, name string) error {
 				if r := recover(); r != nil {
 					stack := debug.Stack()
 					err = fmt.Errorf("panic when aborting workflow, Stack: [%s]", string(stack))
+					logger.Errorf(ctx, err.Error())
 					p.metrics.PanicObserved.Inc(ctx)
 				}
 			}()
@@ -143,6 +144,7 @@ func (p *Propeller) Handle(ctx context.Context, namespace, name string) error {
 					if r := recover(); r != nil {
 						stack := debug.Stack()
 						err = fmt.Errorf("panic when reconciling workflow, Stack: [%s]", string(stack))
+						logger.Errorf(ctx, err.Error())
 						p.metrics.PanicObserved.Inc(ctx)
 					}
 				}()