Bug Fix: erroneous code block (flyteorg#206)

eapolinario · Aug 29, 2021 · 2e8a22b · 2e8a22b
1 parent f8b7007
commit 2e8a22b
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/go/tasks/pluginmachinery/flytek8s/pod_helper.go b/go/tasks/pluginmachinery/flytek8s/pod_helper.go
@@ -339,7 +339,7 @@ func ConvertPodFailureToError(status v1.PodStatus) (code, message string) {
 			containerState = c.State
 		}
 		if containerState.Terminated != nil {
-			if strings.Contains(c.State.Terminated.Reason, OOMKilled) {
+			if strings.Contains(containerState.Terminated.Reason, OOMKilled) {
 				code = OOMKilled
 			} else if containerState.Terminated.ExitCode == SIGKILL {
 				// in some setups, node termination sends SIGKILL to all the containers running on that node. Capturing and

diff --git a/go/tasks/pluginmachinery/flytek8s/pod_helper_test.go b/go/tasks/pluginmachinery/flytek8s/pod_helper_test.go
@@ -774,6 +774,38 @@ func TestConvertPodFailureToError(t *testing.T) {
 		})
 		assert.Equal(t, code, "OOMKilled")
 	})
+
+	t.Run("OOMKilled", func(t *testing.T) {
+		code, _ := ConvertPodFailureToError(v1.PodStatus{
+			ContainerStatuses: []v1.ContainerStatus{
+				{
+					LastTerminationState: v1.ContainerState{
+						Terminated: &v1.ContainerStateTerminated{
+							Reason:   OOMKilled,
+							ExitCode: 137,
+						},
+					},
+				},
+			},
+		})
+		assert.Equal(t, code, "OOMKilled")
+	})
+
+	t.Run("SIGKILL", func(t *testing.T) {
+		code, _ := ConvertPodFailureToError(v1.PodStatus{
+			ContainerStatuses: []v1.ContainerStatus{
+				{
+					LastTerminationState: v1.ContainerState{
+						Terminated: &v1.ContainerStateTerminated{
+							Reason:   "some reason",
+							ExitCode: SIGKILL,
+						},
+					},
+				},
+			},
+		})
+		assert.Equal(t, code, "Interrupted")
+	})
 }
 
 func TestDemystifyPending_testcases(t *testing.T) {