New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.2 - [PATCH][BUGFIX] add onClick handler to emojis #54

Merged

ealush merged 1 commit into master from add-onClick-handlers

Jan 27, 2018

Owner

ealush commented Jan 27, 2018 •

edited

Loading

To support the diversities picker long-click functionality, I used onMouseDown, and remove the click handler, meaning nothing prevents its default.

Clicking emojis added a shebang(#!) to the url, and in react router apps triggered a re-render.

Here I add a preventDefault handler for the picker that stops this from happening.

Related to:
#50


          2.0.2 - [PATCH][BUGFIX] add onClick handler to emojis

ca65608

ealush merged commit 5025868 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet