-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): installation falls back to XMLRPC #171
Conversation
fixes eXist-db#170 Try REST connection, fall back to XMLRPC and inform user that this happened.
I tested this fix locally by setting up an instance that has REST disabled. There is no automated test for this at the moment because do not know how to do this in docker yet. |
@line-o I would create another workflow file, not use
|
@duncdrum Would you be able to share a link to an example? |
and the |
How do we maintain modified configurations for each version of exist that is currently in the testmatrix? |
matrix expansion in the yaml file, something like
|
@duncdrum shouldn't it be more like
|
You can do that, it ll take long to run though. As you need a running container for the copy (I think that’s still the case) If you want to do this I would download them from the containers in the unit test phase, and share as artefact or even commit to repo. Once you commit to repo, you might as well store the changes files and maintain these by hand. Either way works. |
d1f8f5f
to
f1da12a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature
🎉 This PR is included in version 1.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #170
Try REST connection, fall back to XMLRPC and inform user that this happened.