Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add license info Pubd1170 #11

Closed
wants to merge 4 commits into from
Closed

WIP: Add license info Pubd1170 #11

wants to merge 4 commits into from

Conversation

myucekul
Copy link
Contributor

No description provided.

@everreau
Copy link
Contributor

The tests are currently failing but it looks like it's due to inadvertent changes to the whitespace in the template. Unfortunately, I don't immediately know how to fix the tests (other than just adding the new whitespace) because I'm using mock.

It would be good to add a test that tests this functionality.

@myucekul
Copy link
Contributor Author

The tests are currently failing but it looks like it's due to inadvertent changes to the whitespace in the template. Unfortunately, I don't immediately know how to fix the tests (other than just adding the new whitespace) because I'm using mock.

It would be good to add a test that tests this functionality.

Thanks for writing unit tests, Esther. I tried running those on Janeway dev. Please share instructions for executing the tests.

python manage.py test ezid
Creating test database for alias 'default'...
Got an error creating the test database: (1044, "Access denied for user 'janewaydba'@'%' to database 'test_janeway'")

@everreau
Copy link
Contributor

In my PR from yesterday I added documentation to the README about running tests. They have to be run in a development environment or at least an environment where the db user can create and destroy a new database. This is to create a consistent environment to test against.

@myucekul
Copy link
Contributor Author

Closing this. I'll create a new PR.

@myucekul myucekul closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants