Increase cmake minimum required [16436] #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
changed the title
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
force-pushed
the
feature/increase-cmake-minimum
branch
from
7ecedfb to
9dfcab3
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
|
Build status:
|
Signed-off-by: Pablo Garrido <[email protected]>
|
Build status:
|
pablogs9
approved these changes
Dec 8, 2022
Ryanf55
reviewed
Feb 27, 2023
| @@ -15,7 +15,7 @@ | |||
| ############################################################################### | |||
| # CMake build rules for Micro CDR | |||
| ############################################################################### | |||
| cmake_minimum_required(VERSION 3.5.0 FATAL_ERROR) | |||
There was a problem hiding this comment.
CI environment has not yet been updated to have this new version. Linux jobs are failing due to it.
http://jenkins.eprosima.com:8080/view/Micro%20XRCE/job/Micro-CDR%20Nightly%20Master%20Linux/1232/console
[Micro-CDR Nightly Master Linux] $ /home/jenkins/tools/hudson.plugins.cmake.CmakeTool/3.10.0/bin/cmake --version
cmake version 3.10.0
...
CMake Error at CMakeLists.txt:18 (cmake_minimum_required):
CMake 3.15 or higher is required. You are running version 3.10.0
-- Configuring incomplete, errors occurred!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase version to one is being testing our CI