Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22729] Flush logs in CliDiscoveryManager destructor #5673

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Mar 3, 2025

Description

This PR flushes the Logs in the destructor of the CliDiscoveryManager to ensure that all logs are processed before ending the application. This fixes the flaky test in Windows test_fast_discovery_no_XML in which, in some cases, the application was finishing before processing the Error logs, resulting in a false failed test.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v3.2.0 milestone Mar 3, 2025
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima March 3, 2025 09:49
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 3, 2025
@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label Mar 4, 2025
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Running the tests on windows with -R test_fast_discovery_no_XML --repeat until-fail:50 was successful.

@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Mar 5, 2025
@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 6, 2025
@cferreiragonz cferreiragonz merged commit 791012c into master Mar 6, 2025
17 checks passed
@cferreiragonz cferreiragonz deleted the bugfix/windows_flaky_test branch March 6, 2025 09:25
@cferreiragonz cferreiragonz changed the title [22729] Flush logs in CliDiscoveryManager [22729] Flush logs in CliDiscoveryManager destructor Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants