Skip to content

Commit

Permalink
r8169: initialize rtl8169_stats seqlock
Browse files Browse the repository at this point in the history
Boris reports he's seeing:
> [    9.195943] INFO: trying to register non-static key.
> [    9.196031] the code is fine but needs lockdep annotation.
> [    9.196031] turning off the locking correctness validator.
> [    9.196031] CPU: 1 PID: 933 Comm: modprobe Not tainted 3.14.0-rc4+ #1
with the r8169 driver.

These are occuring because the seqcount embedded in u64_stats_sync on
32-bit SMP is uninitialized which is making lockdep unhappy.

Signed-off-by: Kyle McMartin <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
jkkm authored and davem330 committed Feb 25, 2014
1 parent d10473d commit 340fea3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/ethernet/realtek/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -7118,6 +7118,8 @@ rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
}

mutex_init(&tp->wk.mutex);
u64_stats_init(&tp->rx_stats.syncp);
u64_stats_init(&tp->tx_stats.syncp);

/* Get MAC address */
for (i = 0; i < ETH_ALEN; i++)
Expand Down

0 comments on commit 340fea3

Please sign in to comment.