Add poll-based file watcher and use it as default for macOS #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
requested changes
Feb 21, 2022
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/WatchServiceBasedFilePoller.java
Outdated
Show resolved
Hide resolved
joaopgrassi
approved these changes
Feb 22, 2022
arminru
reviewed
Feb 22, 2022
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
pichlermarc
reviewed
Feb 22, 2022
lib/src/main/java/com/dynatrace/file/util/DynatraceFileBasedConfigurationProvider.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/WatchServiceBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
arminru
reviewed
Feb 25, 2022
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
arminru
approved these changes
Feb 28, 2022
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
pirgeo
force-pushed
the
mac-os-polling
branch
2 times, most recently
from
e36b1b6 to
8a2e598
Compare
This reverts commit af4cba0.
Co-authored-by: Marc Pichler <[email protected]>
joaopgrassi
approved these changes
Mar 3, 2022
lib/src/main/java/com/dynatrace/file/util/DynatraceFileBasedConfigurationProvider.java
Show resolved
Hide resolved
arminru
reviewed
Mar 4, 2022
lib/src/main/java/com/dynatrace/file/util/DynatraceFileBasedConfigurationProvider.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/DynatraceFileBasedConfigurationProvider.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/FilePollerFactory.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/dynatrace/file/util/PollBasedFilePoller.java
Outdated
Show resolved
Hide resolved
pichlermarc
approved these changes
Mar 7, 2022
pichlermarc
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new poll based file watcher interface since the WatchService based implementation does not work as intended on macOS. The Poller will poll in 60 Second intervals by default.
@arminru I have added your commits to add macOS to the testing infrastructure in this PR to ensure everything works as intended.