Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oneagent handling #2

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Add oneagent handling #2

merged 3 commits into from
Jul 23, 2020

Conversation

thschue
Copy link

@thschue thschue commented Jul 21, 2020

  • Made the OneAgent metrics endpoint the default
  • When this is used, no API-Token is needed
  • And the Authorization Header will not be set
  • Otherwise, the API Token is required

@thschue thschue requested review from danielkhan and agrimmer July 21, 2020 06:09
agrimmer
agrimmer approved these changes Jul 22, 2020
View reviewed changes
Copy link

@agrimmer agrimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 3aa5d94 into master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrimmer agrimmer agrimmer approved these changes

@danielkhan danielkhan Awaiting requested review from danielkhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thschue @agrimmer