fix(pnl): Fix PNL ticks leaderboard test flakiness (backport #2738) #2740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The PNL ticks leaderboard test was failing intermittently due to inconsistent date handling in the test data setup, where timestamps were being dynamically generated using JavaScript's DateTime, making the test results dependent on when the test was run.
Solution
Fixed the test data setup in
pnl-ticks-table.test.ts
to ensure consistent timestamp handling by:DateTime.utc().startOf('day')
to ensure all test data timestamps are aligned to UTC midnightcreatedAt
andblockTime
fields use consistent timestamps in the test dataTest Plan
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
This is an automatic backport of pull request #2738 done by [Mergify](https://mergify.com).