Use alphanumeric suffix for username

[teddyding]

Changelist

Expand username space and reduce collision

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features

  • Enhanced username generation with a new random suffix instead of a random number.
  • Increased batch size for username generation from 1000 to 2000.

• Bug Fixes

  • Updated expected usernames in tests to reflect changes in username generation logic.

• Improvements

  • Added performance measurement and logging enhancements for username generation tasks.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes changes to the username generation logic within the roundtable service. It updates the configuration for username generation, modifies the implementation of the generateUsernameForSubaccount function to create a random suffix instead of a random number, and enhances logging in the runTask function to include execution duration metrics. Additionally, the test cases for the username generation have been adjusted to reflect the new expected output.

Changes

File	Change Summary
indexer/services/roundtable/__tests__/helpers/usernames-helper.test.ts	Updated expected usernames in the test for generateUsernameForSubaccount function.
indexer/services/roundtable/src/config.ts	Renamed SUBACCOUNT_USERNAME_NUM_RANDOM_DIGITS to SUBACCOUNT_USERNAME_SUFFIX_RANDOM_DIGITS and updated SUBACCOUNT_USERNAME_BATCH_SIZE from 1000 to 2000.
indexer/services/roundtable/src/helpers/usernames-helper.ts	Modified generateUsernameForSubaccount to generate a random suffix using uppercase letters and digits instead of a random number.
indexer/services/roundtable/src/tasks/subaccount-username-generator.ts	Enhanced runTask to log execution duration and added timing metrics for username generation.

Possibly related PRs

• [OTE-540] Add roundtable task to generate usernames #1932: This PR introduces a roundtable task to generate usernames, which directly relates to the changes made in the main PR regarding the generateUsernameForSubaccount function and its testing.
• enable username generation roundtable #2361: This PR updates the configuration for username generation, which is relevant to the changes in the main PR that involve username generation logic.
• [OTE-863] update username generation query #2482: This PR modifies the SQL query in the getSubaccountsWithoutUsernames function, which is related to the overall functionality of username generation discussed in the main PR.

Suggested labels

feature:indexer/affiliates

Suggested reviewers

• affanv14
• jerryfan01234

🐰 In the meadow, usernames bloom,
With digits and letters, dispelling the gloom.
A suffix now dances, a change in the air,
Generating joy, with usernames rare!
So hop along, let the new names take flight,
In the roundtable's realm, all feels just right! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[teddyding]

@Mergifyio backport/release/indexer/v7.x

[mergify]

backport /release/indexer/v7.x

❌ Sorry but I didn't understand the arguments of the command backport. Please consult the commands documentation 📚.

[teddyding]

@Mergifyio backport release/indexer/v7.x

[mergify]

backport release/indexer/v7.x

✅ Backports have been created

• #2574 Use alphanumeric suffix for username (backport #2573) has been created for branch release/indexer/v7.x