De-duplicate and filter out invalid pnl ticks for megavault. (backport #2540) #2545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Add logic to de-duplicate pnl ticks for the same vault when combining PnL of multiple vaults to derive the megavault PnL.
Add logic to filter out megavault Pnl ticks that are aggregated from less Pnl ticks than the number of vaults existing at the time of the Pnl tick.
Both changes are to filter out inconsistencies caused by issues with the PnL task, where it either:
Test Plan
Updated unit tests.
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
Release Notes
New Features
AggregatedPnlTick
for improved handling of profit and loss (P&L) tick data.vincentc/dedup-filter-ticks
.Bug Fixes
GET /megavault/historicalPnl
endpoint.Chores
This is an automatic backport of pull request #2540 done by [Mergify](https://mergify.com).