Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return undefined from getOrderbookMidPriceMap (backport #2441) #2486

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2024

Changelist

Removes code that hits the OrderbookCache when generating candles. This change will be fixed in a later update

Summary by CodeRabbit

  • Bug Fixes

    • Streamlined test cases by removing redundant checks related to order book mid prices.
    • Adjusted expectations in tests to reflect changes in handling order book prices.
  • New Features

    • Updated the getOrderbookMidPriceMap function to return undefined for order book mid prices, indicating a shift in data retrieval logic.
  • Refactor

    • Removed Redis integration for fetching median prices, simplifying the price retrieval process in the CandlesGenerator.

This is an automatic backport of pull request #2441 done by [Mergify](https://mergify.com).

(cherry picked from commit 9fecfc5)

# Conflicts:
#	indexer/services/ender/__tests__/lib/candles-generator.test.ts
@mergify mergify bot requested a review from a team as a code owner October 15, 2024 15:00
@mergify mergify bot added the conflicts label Oct 15, 2024
Copy link
Contributor Author

mergify bot commented Oct 15, 2024

Cherry-pick of 9fecfc5 has failed:

On branch mergify/bp/release/indexer/v7.x/pr-2441
Your branch is up to date with 'origin/release/indexer/v7.x'.

You are currently cherry-picking commit 9fecfc5d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   indexer/services/ender/src/lib/candles-generator.ts

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   indexer/services/ender/__tests__/lib/candles-generator.test.ts

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@adamfraser adamfraser merged commit 7a2200e into release/indexer/v7.x Oct 15, 2024
16 checks passed
@adamfraser adamfraser deleted the mergify/bp/release/indexer/v7.x/pr-2441 branch October 15, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants