Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vault endpoint performance. (backport #2475) #2484

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 14, 2024

Changelist

Fetch funding index update maps in bulk rather than one at a time per vault.

Test Plan

Unit tests.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Introduced a new method to retrieve funding index maps for multiple effective heights, enhancing data retrieval capabilities.
  • Bug Fixes

    • Optimized the getVaultPositions function for improved performance in fetching funding index maps.
  • Documentation

    • Updated method signatures and interfaces for better clarity and usability.
  • Refactor

    • Streamlined data retrieval logic in the VaultController to enhance efficiency and readability.

This is an automatic backport of pull request #2475 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 14, 2024 20:33
@vincentwschau vincentwschau merged commit 071aa31 into release/indexer/v7.x Oct 15, 2024
16 checks passed
@vincentwschau vincentwschau deleted the mergify/bp/release/indexer/v7.x/pr-2475 branch October 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant