Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove volatile market #1263

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Remove volatile market #1263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol/testing/testnet-dev/dev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ create_validators() {
# Using "@" as a subscript results in separate args: "dydx1..." "dydx1..." "dydx1..."
# Note: `edit_genesis` must be called before `add-genesis-account`.
edit_genesis "$VAL_CONFIG_DIR" "${TEST_ACCOUNTS[*]}" "${FAUCET_ACCOUNTS[*]}" "" "" "" ""
update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR"
# update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR"
update_genesis_complete_bridge_delay "$VAL_CONFIG_DIR" "600"

for acct in "${TEST_ACCOUNTS[@]}"; do
Comment on lines 135 to 141
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [142-142]

It's recommended to double-quote variables in shell scripts to prevent globbing and word splitting. This applies to the usage of $USDC_DENOM and $NATIVE_TOKEN within the dydxprotocold add-genesis-account command.

- dydxprotocold add-genesis-account "$acct" 100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN --home "$VAL_HOME_DIR"
+ dydxprotocold add-genesis-account "$acct" "100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN" --home "$VAL_HOME_DIR"

Also applies to: 145-145, 148-148

Expand Down
2 changes: 1 addition & 1 deletion protocol/testing/testnet-staging/staging.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ create_validators() {
# Using "@" as a subscript results in separate args: "dydx1..." "dydx1..." "dydx1..."
# Note: `edit_genesis` must be called before `add-genesis-account`.
edit_genesis "$VAL_CONFIG_DIR" "${TEST_ACCOUNTS[*]}" "${FAUCET_ACCOUNTS[*]}" "" "" "" ""
update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR"
# update_genesis_use_test_volatile_market "$VAL_CONFIG_DIR"
update_genesis_complete_bridge_delay "$VAL_CONFIG_DIR" "600"

for acct in "${TEST_ACCOUNTS[@]}"; do
Comment on lines 189 to 195
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [196-196]

Similar to the dev.sh script, it's recommended to double-quote variables in shell scripts to prevent globbing and word splitting. This applies to the usage of $USDC_DENOM and $NATIVE_TOKEN within the dydxprotocold add-genesis-account command in the staging environment as well.

- dydxprotocold add-genesis-account "$acct" 100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN --home "$VAL_HOME_DIR"
+ dydxprotocold add-genesis-account "$acct" "100000000000000000$USDC_DENOM,$TESTNET_VALIDATOR_NATIVE_TOKEN_BALANCE$NATIVE_TOKEN" --home "$VAL_HOME_DIR"

Also applies to: 199-199, 202-202

Expand Down
Loading