address comments

Signed-off-by: Shrenuj Bansal <[email protected]>
dydxprotocol · Mar 4, 2024 · e10accd · e10accd
1 parent 8cdea7c
commit e10accd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/protocol/x/clob/keeper/deleveraging.go b/protocol/x/clob/keeper/deleveraging.go
@@ -130,7 +130,8 @@ func (k Keeper) MaybeDeleverageSubaccount(
 	return quantumsDeleveraged, err
 }
 
-// GetInsuranceFundBalance returns the current balance of the insurance fund (in quote quantums).
+// GetInsuranceFundBalance returns the current balance of the specific insurance fund based on the
+// perpetual (in quote quantums).
 // This calls the Bank Keeper’s GetBalance() function for the Module Address of the insurance fund.
 func (k Keeper) GetInsuranceFundBalance(ctx sdk.Context, perpetualId uint32) (balance *big.Int) {
 	usdcAsset, exists := k.assetsKeeper.GetAsset(ctx, assettypes.AssetUsdc.Id)

diff --git a/protocol/x/subaccounts/keeper/transfer_test.go b/protocol/x/subaccounts/keeper/transfer_test.go
@@ -731,6 +731,15 @@ func TestTransferInsuranceFundPayments(t *testing.T) {
 			expectedInsuranceFundBalance:        300,
 			expectedErr:                         sdkerrors.ErrInsufficientFunds,
 		},
+		"failure - isolated market insurance fund does not have sufficient funds": {
+			perpetual:                           constants.IsoUsd_IsolatedMarket,
+			insuranceFundBalance:                300,
+			subaccountModuleAccBalance:          2500,
+			quantums:                            big.NewInt(-500),
+			expectedSubaccountsModuleAccBalance: 2500,
+			expectedInsuranceFundBalance:        300,
+			expectedErr:                         sdkerrors.ErrInsufficientFunds,
+		},
 		"panics - asset doesn't exist": {
 			perpetual:                           constants.BtcUsd_SmallMarginRequirement,
 			insuranceFundBalance:                1500,