address comments and fix tests

Signed-off-by: Shrenuj Bansal <[email protected]>
dydxprotocol · Mar 4, 2024 · 8372175 · 8372175
1 parent f62f84d
commit 8372175
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 13 deletions.
diff --git a/protocol/testutil/constants/perpetuals.go b/protocol/testutil/constants/perpetuals.go
@@ -350,18 +350,7 @@ var TestMarketPerpetuals = []perptypes.Perpetual{
 		},
 		FundingIndex: dtypes.ZeroInt(),
 	},
-	{
-		Params: perptypes.PerpetualParams{
-			Id:                3,
-			Ticker:            "ISO-USD",
-			MarketId:          uint32(3),
-			AtomicResolution:  int32(-9),
-			DefaultFundingPpm: int32(0),
-			LiquidityTier:     uint32(3),
-			MarketType:        perptypes.PerpetualMarketType_PERPETUAL_MARKET_TYPE_ISOLATED,
-		},
-		FundingIndex: dtypes.ZeroInt(),
-	},
+	IsoUsd_IsolatedMarket,
 }
 
 // AddPremiumVotes messages.

diff --git a/protocol/x/clob/keeper/deleveraging.go b/protocol/x/clob/keeper/deleveraging.go
@@ -155,7 +155,7 @@ func (k Keeper) GetInsuranceFundBalance(ctx sdk.Context, perpetualId uint32) (ba
 func (k Keeper) GetCrossInsuranceFundBalance(ctx sdk.Context) (balance *big.Int) {
 	usdcAsset, exists := k.assetsKeeper.GetAsset(ctx, assettypes.AssetUsdc.Id)
 	if !exists {
-		panic("GetInsuranceFundBalance: Usdc asset not found in state")
+		panic("GetCrossInsuranceFundBalance: Usdc asset not found in state")
 	}
 	insuranceFundBalance := k.bankKeeper.GetBalance(
 		ctx,

diff --git a/protocol/x/clob/keeper/liquidations_test.go b/protocol/x/clob/keeper/liquidations_test.go
@@ -1982,6 +1982,13 @@ func TestPlacePerpetualLiquidation_Deleveraging(t *testing.T) {
 				mock.Anything,
 				mock.Anything,
 			).Return(nil)
+			bankKeeper.On(
+				"SendCoins",
+				mock.Anything,
+				mock.Anything,
+				mock.Anything,
+				mock.Anything,
+			).Return(nil)
 			bankKeeper.On(
 				"GetBalance",
 				mock.Anything,
@@ -4625,6 +4632,13 @@ func TestMaybeGetLiquidationOrder(t *testing.T) {
 				mock.Anything,
 				mock.Anything,
 			).Return(nil)
+			mockBankKeeper.On(
+				"SendCoinsFromModuleToModule",
+				mock.Anything,
+				mock.Anything,
+				mock.Anything,
+				mock.Anything,
+			).Return(nil)
 			// Give the insurance fund a 1M USDC balance.
 			mockBankKeeper.On(
 				"GetBalance",

diff --git a/protocol/x/clob/keeper/mev_test.go b/protocol/x/clob/keeper/mev_test.go
@@ -836,6 +836,13 @@ func TestRecordMevMetrics(t *testing.T) {
 				mock.Anything,
 				mock.Anything,
 			).Return(nil)
+			mockBankKeeper.On(
+				"SendCoins",
+				mock.Anything,
+				mock.Anything,
+				mock.Anything,
+				mock.Anything,
+			).Return(nil)
 			mockBankKeeper.On(
 				"GetBalance",
 				mock.Anything,